Issue Details (XML | Word | Printable)

Key: KATTA-189
Type: Improvement Improvement
Status: Resolved Resolved
Resolution: Fixed
Priority: Trivial Trivial
Assignee: Johannes Zillmann
Reporter: Mathias Walter
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Katta

improve multithreaded shard search by using ExecutorCompletionService

Created: 14/Mar/11 10:54 AM   Updated: 14/May/11 04:44 PM
Component/s: search
Affects Version/s: 0.6.3
Fix Version/s: 0.6.4

File Attachments: 1. Text File KATTA-189.patch (4 kB)



 Description  « Hide
The multithread shard search can be slightly improved by the use of CompletionService. Currently the multithread search is done by creating a SearchCall for every shard and submitting them to the thread pool. Later on, the search function waits for each submitted SearchCall in the order they are submitted rather in the order they are finished. In the worst case the first SearchCall takes much longer than the later once. All finished SearchCalls are unprocessed until the first SearchCall gets finished. This can increase the memory consumption (later gc) and decrease processing speed.

The attached patch fixes this by using ExecutorCompletionService.



 All   Comments   Change History   git Commits      Sort Order: Ascending order - Click to sort in descending order
Johannes Zillmann added a comment - 14/May/11 04:44 PM
nice, thanks!